Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong message when cell type wheel got too much data to display #425

Closed
ke4 opened this issue Jun 21, 2024 · 6 comments
Closed

Wrong message when cell type wheel got too much data to display #425

ke4 opened this issue Jun 21, 2024 · 6 comments
Assignees
Labels
bug Something isn't working improvement Improve/refactor existing code

Comments

@ke4
Copy link
Contributor

ke4 commented Jun 21, 2024

In the Single Cell Expression Atlas when you do a metadata search for homo sapiens you got the following message on screen:
No data to display.

Steps to reproduce:
Go to this link: https://www.ebi.ac.uk/gxa/sc/search/metadata/homo%20sapiens

Expected result:
Message should be: 'Too much data to display. Please narrow down your search.`

Actual result:
Message: No data to display.

@ke4 ke4 changed the title When cell type wheel got too many data to display it should state it Wrong message when cell type wheel got too many data to display Jun 21, 2024
@ke4 ke4 changed the title Wrong message when cell type wheel got too many data to display Wrong message when cell type wheel got too much data to display Jun 21, 2024
@ke4 ke4 added the improvement Improve/refactor existing code label Jun 21, 2024
@ke4
Copy link
Contributor Author

ke4 commented Jul 4, 2024

I tested this on staging with the new version of the web app.
I used Homo Sapiens as the Search Term.
I could replicate this bug, so I am going to put this into the current sprint and assign it to myself.

Image

@ke4
Copy link
Contributor Author

ke4 commented Jul 24, 2024

Ah, we got this error:
Highcharts warning # 12: http://www.highcharts.com/errors/12/
Highcharts expects point configuration to be numbers or arrays in turbo mode
This error occurs if the series.data option contains object configurations and the number of points exceeds the turboThreshold. It can be fixed by either setting turboThreshold to a higher value, or changing the point configurations to numbers or arrays.
In boost mode, turbo mode is always on, which means only array of numbers or two dimensional arrays are allowed.
See plotOptions.series.turboThreshold

@ke4
Copy link
Contributor Author

ke4 commented Jul 24, 2024

It is probably connected with turboThreshold parameter:
turboThreshold
By default it is set to 1000, you should increase this value in your chart.

@ke4
Copy link
Contributor Author

ke4 commented Jul 24, 2024

From the API documentation:

turboThreshold: number

Since 2.2.0
When a series contains a data array that is longer than this, the Series class looks for data configurations of plain numbers or arrays of numbers. The first and last valid points are checked. If found, the rest of the data is assumed to be the same. This saves expensive data checking and indexing in long series, and makes data-heavy charts render faster.
Set it to 0 disable.
Note:
In boost mode turbo threshold is forced. Only array of numbers or two dimensional arrays are allowed.
In version 11.4.3 and earlier, if object configurations were passed beyond the turbo threshold, a warning was logged in the console and the data series didn't render.
Defaults to 1000.

@ke4
Copy link
Contributor Author

ke4 commented Jul 24, 2024

That is exactly what is happening:
In version 11.4.3 and earlier, if object configurations were passed beyond the turbo threshold, a warning was logged in the console and the data series didn't render.

We are currently using 10.2.1 version:

"node_modules/highcharts": {
      "version": "10.2.1",
      "resolved": "https://registry.npmjs.org/highcharts/-/highcharts-10.2.1.tgz",
      "integrity": "sha512-4QwLQwWc0XdBHXc2Uy6IJisAUir+sgQIMyFqYZc3BD9iFSFUdllLkRyoed6y33aPb73LAMZE2qLB5SuLqFE/fg=="
    }

@ke4 ke4 added the bug Something isn't working label Jul 25, 2024
@ke4
Copy link
Contributor Author

ke4 commented Aug 6, 2024

Tested this on test and staging env. Works fine.

@ke4 ke4 closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Improve/refactor existing code
Projects
None yet
Development

No branches or pull requests

1 participant