Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Fix ] Incorrect cropper library used in readme #401

Open
kostamilorava opened this issue Jun 26, 2023 · 0 comments
Open

[ Fix ] Incorrect cropper library used in readme #401

kostamilorava opened this issue Jun 26, 2023 · 0 comments

Comments

@kostamilorava
Copy link

kostamilorava commented Jun 26, 2023

In readme.md, there is incorrectly linked cropper library. Instead of vuejs-clipper it should be advanced-cropper.

Other than that, only stencil-props configuration is passed, leaving other needed properties like: minWidth, minHeight of cropper area and others aside.

Maybe it's a good idea to pass other configurations as well and override src property (and other needed props) on Vue.js side? This will make sure whole functionality of cropper is available.

Let's merge this pull request and let me know if you think it's a good idea, I might implement solution for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant