Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to request 4096 RSA Key #336

Open
daveyyoung opened this issue Mar 2, 2018 · 8 comments
Open

Unable to request 4096 RSA Key #336

daveyyoung opened this issue Mar 2, 2018 · 8 comments

Comments

@daveyyoung
Copy link

Awesome project, I'm using your PowerShell module with good results for SAN certs...

Following on from this thread:

win-acme/win-acme#29 (comment)

It would be great to be able to up the key size from the default 2048 to 4096 for increased security.

Cheers,

D

@Macharius92
Copy link
Contributor

Hi,

I'm using this awesome tool too ! Any news about allowing a 4096 encryption strength ?

@ebekker
Copy link
Owner

ebekker commented Oct 31, 2018

Unfortunately, out of the box, the in-built private key generator is fixed at 2048-bit. However, if you use an external tool, such as this one to generate a private key in PEM format first, you can specify the key length on it, then input that into the New-ACMECertificate cmdlet with the -KeyPemFile parameter.

@ebekker
Copy link
Owner

ebekker commented Oct 31, 2018

If someone would like to get their feet wet enhancing the module to support input key length, this is a good feature request to do that with. Here's a hint, the small changes that would be needed would done here and here.

@Macharius92
Copy link
Contributor

Any chance you review the PR ? I would love to give a try to a new version to generate certificate with 4096 bits key.

@ebekker
Copy link
Owner

ebekker commented Nov 23, 2018

The PR has been merged and new versions of PWSH modules rebuilt. Can you test the pre-release versions to make sure it works for you: https://www.myget.org/gallery/acmesharp-posh-staging

If you confirm, I'll publish to the gallery, thanks!

@Macharius92
Copy link
Contributor

Just tested it and it works like a charm ! I used the -NumBits4096 flag when calling the New-Certificate commandlet and i now have a certificate signed with a 4096 bits key.

@Macharius92
Copy link
Contributor

@daveyyoung have you tried the pre-release version ? Can you make a feedback so @ebekker will be able to push it to the gallery for everyone ;)

@daveyyoung
Copy link
Author

Hey @Macharius92 , just tested there with a SAN certificate and the -NumBits4096 parameter. Worked effortlessly, thanks to you both for the development!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants