Change semantic of userObjects in nested transaction #3289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Rob,
I want to discuss, if this change makes sense.
We often use
Transaction.putUserObject
to store some context information and use it in TransactionCallbacksWith the last PR, we discovered, that this does not work how we thought, when nested transactions are use.
We expected that user objects are stored at the current scope. So after a try/finally block, the information is gone, but it seems, if there is a transaction open, that the objects are stored at the upper most transaction.
Please take a look at this PR, which will change the behaviour, how userObjects are stored.
Roland