Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: "normal vector pointing towards the origin" is confusing #55

Closed
ghost opened this issue Feb 10, 2016 · 0 comments
Closed

Plane: "normal vector pointing towards the origin" is confusing #55

ghost opened this issue Feb 10, 2016 · 0 comments
Labels

Comments

@ghost
Copy link

ghost commented Feb 10, 2016

As far as I understand, the normal vector of the plane can point in the reverse order than towards the origin.

In graphene_plane_init(), 'constant' is the negative distance. So should the value of 'constant' be positive or negative? Are both positive and negative allowed?

What does graphene_plane_normalize() do? I think it should be documented in the class description. I guess a normalized plane is when the normal vector really points to the origin.

For graphene_plane_negate(), "Negates the normal vector and constant" -> if both values are negated, the result is the same plane, no? Or I've misunderstood something, and it's related to the above comments.

@ebassi ebassi added the docs label Mar 1, 2016
@ebassi ebassi closed this as completed in c32204d Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant