Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Honeycomb integration to use Opentelemetry #30

Open
Fishrock123 opened this issue Dec 7, 2021 · 2 comments
Open

Switch Honeycomb integration to use Opentelemetry #30

Fishrock123 opened this issue Dec 7, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Fishrock123
Copy link
Contributor

Honeycomb is slowly switching to opentelemetry and so should this.

The current honeycomb impl this runs on top of (libhoney-rust) has some issues (inefficiencies, and is likely memory leak source).

Here are some links:

Basically, it needs a tracing subscriber which feeds into opentelemetry.

Additionally there are these but they might already be covered in the tracing integration.

@Fishrock123 Fishrock123 added the enhancement New feature or request label Dec 7, 2021
@Fishrock123
Copy link
Contributor Author

For more information about how the tracing parts work, see it's readme: https://crates.io/crates/tracing

@Fishrock123
Copy link
Contributor Author

Fishrock123 commented Dec 7, 2021

Here is how it is currently wired up:

trace::info! -> tracing (crate) -> tracing-honeycomb (crate, implements tracing-subscriber) -> tracing-distributed (crate) -> libhoney-rust (crate) -> (http send)

Here is what I think it will look like:

trace::info! -> tracing (crate) -> tracing-opentelemetry (crate, implements tracing-subscriber) -> opentelemetry (crate) -> opentelemtry-oltp (crate) -> (http or grpc send)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant