Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider test-data.frame.R #884

Open
IndrajeetPatil opened this issue Jun 8, 2024 · 2 comments
Open

Reconsider test-data.frame.R #884

IndrajeetPatil opened this issue Jun 8, 2024 · 2 comments
Labels
Consistency 🍏 🍎 Expected output across functions or API design could be more similar Low priority 😴 This issue can be easily workaround or happens only in edge cases

Comments

@IndrajeetPatil
Copy link
Member

Is this the right name for this test file? I don't see what these tests have anything to do with data frames 🤔

https://github.com/easystats/insight/blob/main/tests/testthat/test-data.frame.R
@strengejacke
Copy link
Member

All inputs are data frames?

@IndrajeetPatil
Copy link
Member Author

Ah, I see. The . threw me off because that makes it sound like we are testing data frame S3 method.

I think test-data_frame.R would be better. Would be worthwhile to also (conditionally) test tibbles and data table inputs.

@strengejacke strengejacke added Low priority 😴 This issue can be easily workaround or happens only in edge cases Consistency 🍏 🍎 Expected output across functions or API design could be more similar labels Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Consistency 🍏 🍎 Expected output across functions or API design could be more similar Low priority 😴 This issue can be easily workaround or happens only in edge cases
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IndrajeetPatil @strengejacke