Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Slurm as the default job backend + deprecate support for GC3Pie as job backend #4659

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

gkaf89
Copy link

@gkaf89 gkaf89 commented Sep 26, 2024

  • The GC3Pie back-end for job management that has been the default so far is no longer actively supported. Use the Slurm back-end as default instead.
  • Add deprecation message when the GC3Pie class is instantiated.

fixes #4565

@gkaf89 gkaf89 force-pushed the refactor/default-job-backend branch 2 times, most recently from a0e4c19 to 4d08b03 Compare September 26, 2024 22:15
@boegel boegel changed the base branch from develop to 5.0.x September 27, 2024 06:04
@boegel boegel changed the title [refactor:job_backend] Use Slurm as the default job back-end use Slurm as the default job back-end Sep 27, 2024
@boegel boegel added change EasyBuild-5.0 EasyBuild 5.0 labels Sep 27, 2024
easybuild/tools/job/gc3pie.py Outdated Show resolved Hide resolved
@boegel boegel added this to the 5.0 milestone Sep 27, 2024
@gkaf89
Copy link
Author

gkaf89 commented Sep 28, 2024

There is a test that still fails after the latest commit:

test.framework.parallelbuild.ParallelBuildTest.test_build_easyconfigs_in_parallel_gc3pie

I traced the issue in the deprecation message which was added in the GC3Pie constructor. Adding a deprecation message to the log during testing raises an Exception. The test succeeds if the exception is caught. Under normal operation, logging the deprecation message does not raise any exception.

Is there any special handling of deprecation message logging in the tests? How should I handle exceptions caused by deprecation messages in tests?

@boegel
Copy link
Member

boegel commented Sep 30, 2024

Is there any special handling of deprecation message logging in the tests? How should I handle exceptions caused by deprecation messages in tests?

@gkaf89 Just call self.allow_deprecated_behaviour() in the test, there's a bunch of examples of this already in the test suite

@gkaf89 gkaf89 force-pushed the refactor/default-job-backend branch from c029579 to 4d4107a Compare October 2, 2024 08:53
gkaf89 and others added 3 commits October 2, 2024 11:21
- The GC3Pie back-end for job management that has been the default so far
  is no longer actively supported. Use the Slurm back-end as default
  instead.
- Add deprecation message when the GC3Pie class is instantiated.

Issue: easybuilders#4565
Co-authored-by: Kenneth Hoste <[email protected]>
@gkaf89 gkaf89 force-pushed the refactor/default-job-backend branch from 4d4107a to e6391c3 Compare October 2, 2024 09:22
@gkaf89 gkaf89 marked this pull request as ready for review October 2, 2024 09:24
…EasyBuild will no longer support it anymore (v6.0)
…gs_in_parallel_gc3pie + catch deprecation warnings via mocked_stdout_stderr
@boegel boegel changed the title use Slurm as the default job back-end use Slurm as the default job backend + deprecate support for GC3Pie as job backend Oct 2, 2024
@boegel boegel merged commit 18d5c0b into easybuilders:5.0.x Oct 2, 2024
36 checks passed
@gkaf89 gkaf89 deleted the refactor/default-job-backend branch October 2, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants