-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Slurm as the default job backend + deprecate support for GC3Pie as job backend #4659
use Slurm as the default job backend + deprecate support for GC3Pie as job backend #4659
Conversation
a0e4c19
to
4d08b03
Compare
9b1de34
to
c029579
Compare
There is a test that still fails after the latest commit:
I traced the issue in the deprecation message which was added in the GC3Pie constructor. Adding a deprecation message to the log during testing raises an Exception. The test succeeds if the exception is caught. Under normal operation, logging the deprecation message does not raise any exception. Is there any special handling of deprecation message logging in the tests? How should I handle exceptions caused by deprecation messages in tests? |
@gkaf89 Just call |
c029579
to
4d4107a
Compare
- The GC3Pie back-end for job management that has been the default so far is no longer actively supported. Use the Slurm back-end as default instead. - Add deprecation message when the GC3Pie class is instantiated. Issue: easybuilders#4565
Co-authored-by: Kenneth Hoste <[email protected]>
4d4107a
to
e6391c3
Compare
…EasyBuild will no longer support it anymore (v6.0)
…gs_in_parallel_gc3pie + catch deprecation warnings via mocked_stdout_stderr
fixes #4565