disable strict RPATH sanity check by default, allow re-enabling it via --strict-rpath-sanity-check configuration option
#4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
force-pushed
the
strict_rpath_sanity_check
branch
from
121bbe9
to
1989fa3
Compare
…tion of mixing of using RPATH with dependencies that were installed without RPATH
boegel
force-pushed
the
strict_rpath_sanity_check
branch
from
1989fa3
to
1e3153a
Compare
The regex matches the Sadly this may not help us. It looks like there is an RPATH section in all the libraries checked. |
|
Works as designed: The docs page still needs to be created. When using |
boegel
changed the title
Ah, snap, I overlooked that... I can adjust the regex so that doesn't happen, or simply filter out " That does make me wonder: if the RPATH section is there for all dependency libraries, then why are the binaries still unable to find some libraries? |
I'm testing a rebuild with |
And that still fails. |
|
perhaps lammps uses something like |
|
Without and with RPATH both are the same |
|
so, to me it looks like this issue occurs when:
for example, in the case of
|
|
we can figure out where this happens, but the command I came up with isn't exactly quick to run. time find -L $(echo $LIBRARY_PATH | sed -E -e 's/:/ /g' -e "s#$EBROOTHDF5/lib(64|)##g" ) -maxdepth 1 -type f -name '*.so*' -exec sh -c "tmp=\$(readelf -d {}); tmp3=\$(echo \$tmp | grep -q 'RPATH'); if \$(echo \$tmp | grep -q 'libhdf5_hl') && ! \$(echo \$tmp | grep -q 'RPATH') ; then echo {}; fi" \;
/project/boegelbot/Rocky8/haswell/software/netCDF/4.9.2-gompi-2023a/lib/libnetcdf.so.19
/project/boegelbot/Rocky8/haswell/software/netCDF/4.9.2-gompi-2023a/lib/libnetcdf.so
real 0m46.667s
user 0m10.543s
sys 0m35.770s |
|
as an aside, a fast and easy way of detecting a mixed stack would be to grep the latest |
|
Actually, this might be easier than I thought. |
boegel
changed the title
boegel
changed the title
--strict-rpath-sanity-check configuration option
…nd during RPATH sanity check
…sanity-check + also verify behaviour without --strict-rpath-sanity-check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement detection of mixing of using RPATH with dependencies that were installed without RPATH
related: easybuilders/easybuild-easyconfigs#20051
Marked as WIP since I'm still verifying this actually works as designed...(works as intended)