Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for post-install patches #3974

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 1, 2022

Example use case here is a patch that we needed to apply for FLUENT, which can only be done after the installation was performed (because the files to patch don't exist in the unpacked sources, they're hidden deeper down in zipped files, etc.)

@boegel boegel added this to the 4.x milestone Mar 1, 2022
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, I just have a question and minor suggestion

easybuild/framework/easyblock.py Show resolved Hide resolved
easybuild/framework/easyblock.py Outdated Show resolved Hide resolved
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming modified the milestones: 4.x, next release (4.5.4?) Mar 2, 2022
@lexming lexming merged commit ed04e07 into easybuilders:develop Mar 2, 2022
@boegel boegel deleted the post_install_patches branch March 3, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants