run post-install commands specified for a specific extension #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2021
smoors
approved these changes
May 25, 2021
There was a problem hiding this comment.
lgtm
test report in easybuilders/easybuild-easyconfigs#12950
checked that it works with postinstallcmds for both the global easyconfig and extensions
|
Going in, thanks @boegel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, specifying
postinstallcmdsfor a specific extension is futile, they're just ignored becausepost_install_stepis not run for extensions.A workaround was implemented in the
PythonPackageeaysblock for this in easybuilders/easybuild-easyblocks#2381 which introduces a custom easyconfig paramter namedext_postinstallcmds, which is no longer needed thanks to the changes here.Both #3663 and easybuilders/easybuild-easyblocks#2404 can be closed once this is merged.
The custom
ext_postinstallcmdseasyconfig parameter forPythonPackageshould be removed again (it's only there indevelop, not included yet with an EasyBuild release), and the 2 easyconfigs that use it should be tweaked to usepostinstallcmdsinstead (DROP-1.0.3-foss-2020b-R-4.0.3.ebandCNVkit-0.9.8-foss-2020b-R-4.0.3.eb).