mention CPU arch name in comment for uploaded test report, if it's known by archspec #3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmine CPU arch name
|
worth also showing the arch name in |
migueldiascosta
requested changes
Mar 23, 2020
Good point, fixed in 1d571f0, should be good to go now? |
| @@ -1166,6 +1167,11 @@ def show_system_info(self): | |||
| " -> vendor: %s" % system_info['cpu_vendor'], | |||
| " -> architecture: %s" % get_cpu_architecture(), | |||
| " -> family: %s" % get_cpu_family(), | |||
| ] | |||
| if cpu_arch_name: | |||
| lines.append(" -> arch name: %s" % cpu_arch_name) | |||
There was a problem hiding this comment.
I think there is a small inconsistency... if here you mean exactly this, then without archspec it will still be printed, but UNKNOWN, and in test_show_system_info there is no reason to check for HAVE_ARCHSPEC, since the pattern will always be there
otherwise this should be if cpu_arch_name != UNKNOWN, no?
There was a problem hiding this comment.
Maybe we should hint that archspec is not installed when cpu_arch__name == UNKNOWN?
|
Going in, thanks @boegel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leveraging
archspecif it's installed (https://github.com/archspec/archspec)