Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take into account that builddependencies is always a list in EasyBlock.det_iter_cnt #2812

Merged
merged 3 commits into from
Mar 18, 2019

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 18, 2019

@bartoldeman: we overlooked this in #2741

It's only problematic if there is more than one build dependency listed, but it's an important bug to fix...

@boegel boegel added the bug fix label Mar 18, 2019
@boegel boegel added this to the next release (3.8.2) milestone Mar 18, 2019
easybuild/framework/easyblock.py Outdated Show resolved Hide resolved
easybuild/framework/easyblock.py Outdated Show resolved Hide resolved
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ocaisa ocaisa merged commit 2c017d5 into easybuilders:develop Mar 18, 2019
@boegel boegel deleted the fix_det_iter_cnt branch March 18, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants