Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builddir not set correctly when build_in_installdir = True and running --sanity-check-only #3895

Closed
branfosj opened this issue Nov 9, 2021 · 1 comment · Fixed by #3900
Closed
Milestone

Comments

@branfosj
Copy link
Member

branfosj commented Nov 9, 2021

When self.build_in_installdir = True (c.f. OpenFOAM easyblock) and running --sanity-check-only then self.builddir is not set correctly.

Error:

cd: /dev/shm/build-branfosj-admin/branfosj-admin-up/OpenFOAM/8/foss-2020b: No such file or directory

That corresponds to

buildpath                 (E) = /dev/shm/build-branfosj-admin/branfosj-admin-up
@boegel
Copy link
Member

boegel commented Nov 19, 2021

The problem is that self.builddir = self.installdir is only set in make_builddir, which is part of the ready step (that is skipped entirely when using --sanity-check-only).

Fixed in #3900 by moving self.builddir = self.installdir to the EasyBlock constructor, so it's always done, regardless of which steps are run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants