Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{compiler}[GCCcore/4.9.3] LLVM v3.8.1 #3474

Merged
merged 12 commits into from
Aug 31, 2016

Conversation

ocaisa
Copy link
Member

@ocaisa ocaisa commented Aug 25, 2016

(created using eb --new-pr)

@boegel boegel modified the milestone: v2.9.0 Aug 25, 2016
@boegel
Copy link
Member

boegel commented Aug 25, 2016

Test report by @boegel
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in this PR)
node2062.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/35f792073f1206d7da396898b8231eb1 for a full test report.

@boegel
Copy link
Member

boegel commented Aug 25, 2016

@ocaisa Python 2.7 is required for LLVM, hence the failed test report, see also https://github.com/hpcugent/easybuild-easyconfigs/pull/3407/files#diff-a09113334b8d0515546f9225aab5fcf2

@boegel
Copy link
Member

boegel commented Aug 25, 2016

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2485.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/3b3f5fafbfd3ca08e83e33d63efa6967 for a full test report.

@ocaisa
Copy link
Member Author

ocaisa commented Aug 26, 2016

@boegel Looks like Travis doesn't support hidden = True inside an easyconfig yet

@boegel
Copy link
Member

boegel commented Aug 26, 2016

@ocaisa this has nothing to do with Travis, it's a check in resolve_dependencies that is failing, cfr. https://github.com/hpcugent/easybuild-framework/blob/master/easybuild/tools/robot.py#L323

so, the robot is not aware that dependencies may get installed as hidden modules, it's a bug...

@boegel
Copy link
Member

boegel commented Aug 26, 2016

@ocaisa also, I'm not sure if we should include hidden = True in easyconfigs we ship centrally, isn't that a site-specific choice?

@ocaisa
Copy link
Member Author

ocaisa commented Aug 26, 2016

Ok, unhiding it but leaving it in there so people are aware that that's what I think they should do

osdependencies = [('openssl-devel', 'libssl-dev')]

# We hide this by default since users should not use it in production
#hidden = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocaisa can you clarify why this should not be used in production in the comment?
If it's clear, I guess it makes sense to leave this in.

Also, please use --pr-commit-msg with --update-pr to provide meaningful commit messages; I'll look into enforcing that (only --new-pr defaults to somewhat decent auto-derived commit messages)

configopts += "-DLLVM_INSTALL_UTILS=ON"

separate_build_dir = True

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloned

@boegel
Copy link
Member

boegel commented Aug 26, 2016

Test report by @boegel
FAILED
Build succeeded for 4 out of 5 (5 easyconfigs in this PR)
node2539.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/04a662f8ae97c88c6eacb5120ebc80eb for a full test report.

@boegel
Copy link
Member

boegel commented Aug 26, 2016

Test report by @boegel
FAILED
Build succeeded for 3 out of 5 (5 easyconfigs in this PR)
node2130.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/bdea1c7a6a089f8dacfb5a9941929e9a for a full test report.

@boegel
Copy link
Member

boegel commented Aug 26, 2016

  • sanity check for LLVM 3.8.1 failed on CentOS7 because bin/FileCheck is not there (which is weird, since I can see it getting built in the log...)
  • build on Python bare on SL6 failed with collect2: fatal error: cannot find 'ld' for an unknown reason... I'll retrigger that test, may have been influenced by another build on the same system

@boegel
Copy link
Member

boegel commented Aug 26, 2016

Test report by @boegel
FAILED
Build succeeded for 3 out of 5 (5 easyconfigs in this PR)
node2130.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/636862c6db3f652876aa556a03780adf for a full test report.

@boegel
Copy link
Member

boegel commented Aug 26, 2016

@ocaisa is the problem with Python bare on SL6 caused by a missing build dep on binutils?

...since python may be called on its own
@boegel
Copy link
Member

boegel commented Aug 29, 2016

Test report by @boegel
FAILED
Build succeeded for 4 out of 5 (5 easyconfigs in this PR)
node2427.golett.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/b615bd461d543d0a82f6de247edecfb4 for a full test report.

@boegel
Copy link
Member

boegel commented Aug 29, 2016

@ocaisa still failing on the missing bin/FileCheck... I think it should be there though, this looks like a genuine issue to me?

since we have a bin directory
@ocaisa
Copy link
Member Author

ocaisa commented Aug 31, 2016

I can't reproduce this, is it possible to get the full log?

I probably have a poor understanding of this but should binutils be a dep or a builddep in this case? Do I need bintuils at runtime for executables?

@ocaisa
Copy link
Member Author

ocaisa commented Aug 31, 2016

Ah, I can reproduce this. I was using the default sanity check. Ok, let me take a look.

@boegel
Copy link
Member

boegel commented Aug 31, 2016

@ocaisa binutils should be a build dep when GCCcore is the toolchain, it's not needed at runtime

@@ -28,7 +28,7 @@ dependencies = [
('ncurses', '6.0'),
]

configopts = '-DBUILD_SHARED_LIBS=ON'
configopts = '-DBUILD_SHARED_LIBS=ON '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice catch!

@ocaisa
Copy link
Member Author

ocaisa commented Aug 31, 2016

Should build now, testing...

@ocaisa
Copy link
Member Author

ocaisa commented Aug 31, 2016

Built successfully, FileCheck in place

@boegel
Copy link
Member

boegel commented Aug 31, 2016

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
node2610.swalot.os - Linux centos linux 7.2.1511, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/b561ee74a5d389dac78e6b9b95a6fb0c for a full test report.

@boegel
Copy link
Member

boegel commented Aug 31, 2016

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
node2001.delcatty.os - Linux SL 6.8, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/2a2e2eef628de285929653a5a1973ccc for a full test report.

@boegel
Copy link
Member

boegel commented Aug 31, 2016

lgtm

@boegel
Copy link
Member

boegel commented Aug 31, 2016

Going in, thanks @ocaisa!

@boegel boegel merged commit c2a3e1c into easybuilders:develop Aug 31, 2016
@ocaisa ocaisa deleted the 20160825161435_new_pr_LLVM381 branch August 31, 2016 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants