-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use skani rather than FastANI as dependency for GTDB-Tk v2.4.0 #21518
use skani rather than FastANI as dependency for GTDB-Tk v2.4.0 #21518
Conversation
@akesandgren Can you edit the PR description to motivate this change? |
Description updated |
@akesandgren So what happens if |
It builds with FastANI but I didn't check if that version actually worked or not. |
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2458875341 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
@boegelbot please test @ jsc-zen3 |
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2459170010 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegel |
Going in, thanks @akesandgren! |
(created using
eb --new-pr
)As per the description of GTDB-Tk v2.4.0: