Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use skani rather than FastANI as dependency for GTDB-Tk v2.4.0 #21518

Merged

Conversation

akesandgren
Copy link
Contributor

@akesandgren akesandgren commented Oct 2, 2024

(created using eb --new-pr)

As per the description of GTDB-Tk v2.4.0:

GTDB-Tk v2.4.0+ includes the following new features:

FastANI has been replaced by skani as the primary tool for computing Average Nucleotide Identity (ANI).Users may notice slight variations in the results compared to those obtained using FastANI.

@boegel boegel added new and removed update labels Oct 9, 2024
@boegel boegel added this to the release after 4.9.4 milestone Oct 9, 2024
@boegel
Copy link
Member

boegel commented Oct 9, 2024

@akesandgren Can you edit the PR description to motivate this change?

@akesandgren
Copy link
Contributor Author

Description updated

@boegel
Copy link
Member

boegel commented Oct 9, 2024

@akesandgren So what happens if skani is not around, do users see failing runs?

@akesandgren
Copy link
Contributor Author

It builds with FastANI but I didn't check if that version actually worked or not.

@boegel
Copy link
Member

boegel commented Nov 6, 2024

@boegelbot please test @ generoso

@boegel boegel added the bug fix label Nov 6, 2024
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21518 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21518 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14625

Test results coming soon (I hope)...

- notification for comment with ID 2458875341 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/fb006d09790a840d72e0b980d69c3bd5 for a full test report.

@boegel
Copy link
Member

boegel commented Nov 6, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21518 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21518 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5197

Test results coming soon (I hope)...

- notification for comment with ID 2459170010 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/56fc45ff71865c0dec64c3d74c219658 for a full test report.

@boegel boegel changed the title GTDB-Tk v2.4.0 should use skani and not FastANI use skani rather than FastANI as dependency for GTDB-Tk v2.4.0 Nov 6, 2024
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Nov 6, 2024

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3103.skitty.os - Linux RHEL 9.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.9.18
See https://gist.github.com/boegel/f0212581dd3326a2ca5694283746b8a7 for a full test report.

@boegel
Copy link
Member

boegel commented Nov 6, 2024

Going in, thanks @akesandgren!

@boegel boegel merged commit 7f227d2 into easybuilders:develop Nov 6, 2024
9 checks passed
@akesandgren akesandgren deleted the 20241002144236_new_pr_GTDB-Tk240 branch November 7, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants