-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{lang}[iimkl/2023b] SciPy-bundle v2023.12 #20262
base: develop
Are you sure you want to change the base?
{lang}[iimkl/2023b] SciPy-bundle v2023.12 #20262
Conversation
…scipy-1.11.4_disable-test_branch_cut.patch, numpy-1.26.2_fix_selected_kind_for_ifort.patch
# order is important! | ||
exts_list = [ | ||
('numpy', '1.26.2', { | ||
'easyblock': 'PythonPackage', # pip install builds numpy v1.26.x via spin/meson/ninja |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature isn't really documented
Am I allowed to use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not disallowed, though this would mean we e.g. aren't running test step (and all the other good stuff that presumably is done in that easyblock, like picking up fft etc.)
I would like to input from one of the authors of the numpy easyblock. I only recognize @boegel names there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifying a custom easyblock for a particular extension like this is fine in general, but bypassing the custom easyblock for numpy
specifically is a bit of a "red flag" (strongly worded).
It seems like that may point to a fix being needed in the numpy easyblock instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like that may point to a fix being needed in the numpy easyblock instead?
Yes, that's what I thought first too. One might say that the numpy
easyblock need to evolve along with the changes in numpy
's build system (v1.26.0).
Similarly to what happened to the SciPy
easyblock (pr 2862), when there were changes in SciPy
's build system (v1.9).
But I'm in doubt, because the new build system is (advertised as) simpler, then why would we making our easyblock more complex? If the generic pythonpackage
works better than the bespoke numpy
block, we have an opportunity to be leaner.
I want to do what happened with SciPy block, but I want it to be a oneliner. One test that makes it revert to the generic case, say if LooseVersion(self.version) >= LooseVersion('1.26')
. I don't like the idea of adding many if self.use_meson
statements in the block, doubling it.
Am I missing something? Those tests that @Micket mentioned? Please let me know what you think.
easybuild/easyconfigs/s/SciPy-bundle/SciPy-bundle-2023.12-iimkl-2023b.eb
Show resolved
Hide resolved
I've added SciPy-bundle-2023.12-gfbf-2023b.eb to complete the pair (they both have the numpy extension using the spin/meson/ninja build via pip install) I suppose a pair of version 2023.11 could be completed by adding the iimkl build, but it seems tedious to do and I think it might also not desired... |
I'm not sure if it's a good idea to introduce another For @Louwrensth Do you recall what kind of trouble you ran into with |
Good call. I don't recall, but I found a stash. I'll:
|
f402080
to
59d13d8
Compare
Test report by @boegelbot |
(created using
eb --new-pr
)