-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consistently use system toolchain in EasyBuild easyconfigs #15126
consistently use system toolchain in EasyBuild easyconfigs #15126
Conversation
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1066064921 processed Message to humans: this is just bookkeeping information for me, |
We should cleanup the dummy toolchain check in the testsuite: https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/test/easyconfigs/easyconfigs.py#L1216 to remove the exception for these easyconfigs. |
@branfosj Good point, fixed in 2b0d51441d691dab9d9726e9896f3fa9de0922a4 |
2b0d514
to
ff80fa2
Compare
Test report by @boegelbot |
Test report by @boegel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Going in, thanks @boegel! |
(created using
eb --new-pr
)We were sticking to use the
dummy
toolchain, which is essentially a deprecated alias forsystem
, to facilitate updating from EasyBuild 3.x (which does not know about thesystem
toolchain yet) to EasyBuild 4.x .The latest EasyBuild User Survey shows that only a very small minority (~2%) is still using EasyBuild 3.x, so the time has come to clean this up...
closes #10404