Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistently use system toolchain in EasyBuild easyconfigs #15126

Merged

Conversation

boegel
Copy link
Member

@boegel boegel commented Mar 13, 2022

(created using eb --new-pr)

We were sticking to use the dummy toolchain, which is essentially a deprecated alias for system, to facilitate updating from EasyBuild 3.x (which does not know about the system toolchain yet) to EasyBuild 4.x .

The latest EasyBuild User Survey shows that only a very small minority (~2%) is still using EasyBuild 3.x, so the time has come to clean this up...

closes #10404

@boegel
Copy link
Member Author

boegel commented Mar 13, 2022

@boegelbot please test @ generoso
EB_ARGS="EasyBuild-4.0.0.eb EasyBuild-4.0.1.eb EasyBuild-4.1.0.eb EasyBuild-4.1.1.eb EasyBuild-4.1.2.eb EasyBuild-4.2.0.eb EasyBuild-4.2.1.eb EasyBuild-4.2.2.eb EasyBuild-4.3.0.eb EasyBuild-4.3.1.eb EasyBuild-4.3.2.eb EasyBuild-4.3.3.eb EasyBuild-4.3.4.eb EasyBuild-4.4.0.eb EasyBuild-4.4.1.eb EasyBuild-4.4.2.eb EasyBuild-4.5.0.eb EasyBuild-4.5.1.eb EasyBuild-4.5.2.eb EasyBuild-4.5.3.eb"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15126 EB_ARGS="EasyBuild-4.0.0.eb EasyBuild-4.0.1.eb EasyBuild-4.1.0.eb EasyBuild-4.1.1.eb EasyBuild-4.1.2.eb EasyBuild-4.2.0.eb EasyBuild-4.2.1.eb EasyBuild-4.2.2.eb EasyBuild-4.3.0.eb EasyBuild-4.3.1.eb EasyBuild-4.3.2.eb EasyBuild-4.3.3.eb EasyBuild-4.3.4.eb EasyBuild-4.4.0.eb EasyBuild-4.4.1.eb EasyBuild-4.4.2.eb EasyBuild-4.5.0.eb EasyBuild-4.5.1.eb EasyBuild-4.5.2.eb EasyBuild-4.5.3.eb" /opt/software/slurm/bin/sbatch --job-name test_PR_15126 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8274

Test results coming soon (I hope)...

- notification for comment with ID 1066064921 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Member

We should cleanup the dummy toolchain check in the testsuite: https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/test/easyconfigs/easyconfigs.py#L1216 to remove the exception for these easyconfigs.

@boegel
Copy link
Member Author

boegel commented Mar 13, 2022

@branfosj Good point, fixed in 2b0d51441d691dab9d9726e9896f3fa9de0922a4

@boegel boegel force-pushed the 20220313103705_new_pr_EasyBuild394 branch from 2b0d514 to ff80fa2 Compare March 13, 2022 10:08
@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 20 out of 20 (20 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/b8f053f42a196a1aa3b2a763e4da36ff for a full test report.

@boegel
Copy link
Member Author

boegel commented Mar 13, 2022

Test report by @boegel
SUCCESS
Build succeeded for 21 out of 21 (21 easyconfigs in total)
node2671.swalot.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/e7a8b4557033b39d66f131a7b2d5983a for a full test report.

Copy link
Member

@branfosj branfosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj
Copy link
Member

Going in, thanks @boegel!

@branfosj branfosj merged commit c6b7c4c into easybuilders:develop Mar 14, 2022
@boegel boegel deleted the 20220313103705_new_pr_EasyBuild394 branch March 15, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants