-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add patch for Clang v9.0.1 to fix installation problem #15007
base: develop
Are you sure you want to change the base?
add patch for Clang v9.0.1 to fix installation problem #15007
Conversation
@@ -0,0 +1,11 @@ | |||
--- llvm-9.0.1.src/projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc.orig 2020-03-11 20:35:37.099808821 +0100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexandermichels Please add a short description on top of the patch to describe what it does, why it's needed, and/or which errors it's fixing exactly.
Also mention author or add a reference to upstream fix.
Do take into account that this implies also changing the SHA256 checksums for this patch file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking further through https://bugs.gentoo.org/708430 I think we want https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-libs/compiler-rt-sanitizers/files/9.0.1/glibc-2.31.patch?id=2741567d6f7fb139c8ad37137fb581987a779e97
Just commenting out that check will be fine for newer glibc, but some will require it:
+/* glibc 2.30 and earlier provided 16-bit mode field instead of 32-bit
+ on many architectures. */
That also looks close to the equivalent patch for GCC: https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/g/GCCcore/GCCcore-9.2.0-fix-glibc-2.31-libsanitizer.patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1361513967 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
(created using
eb --new-pr
)fixes #14998