Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patch for Clang v9.0.1 to fix installation problem #15007

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

alexandermichels
Copy link
Contributor

@alexandermichels alexandermichels commented Feb 16, 2022

(created using eb --new-pr)

fixes #14998

@alexandermichels
Copy link
Contributor Author

Patch to fix issue reported in #14998. Thank you to @branfosj for providing the solution!

@@ -0,0 +1,11 @@
--- llvm-9.0.1.src/projects/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cc.orig 2020-03-11 20:35:37.099808821 +0100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexandermichels Please add a short description on top of the patch to describe what it does, why it's needed, and/or which errors it's fixing exactly.

Also mention author or add a reference to upstream fix.

Do take into account that this implies also changing the SHA256 checksums for this patch file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking further through https://bugs.gentoo.org/708430 I think we want https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-libs/compiler-rt-sanitizers/files/9.0.1/glibc-2.31.patch?id=2741567d6f7fb139c8ad37137fb581987a779e97

Just commenting out that check will be fine for newer glibc, but some will require it:

+/* glibc 2.30 and earlier provided 16-bit mode field instead of 32-bit
+   on many architectures.  */

That also looks close to the equivalent patch for GCC: https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/g/GCCcore/GCCcore-9.2.0-fix-glibc-2.31-libsanitizer.patch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel I added a short description to the patch file.

@branfosj I can test out the patch you linked.

@boegel boegel added the bug fix label Feb 17, 2022
@boegel boegel added this to the next release (4.5.4?) milestone Feb 17, 2022
@boegel
Copy link
Member

boegel commented Dec 21, 2022

@boegelbot please test @ generoso
EB_ARGS="--installpath /tmp/pr15007"

@boegel boegel changed the title patch for Clang-9.0.1-GCCcore add patch for Clang v9.0.1 to fix installation problem Dec 21, 2022
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=15007 EB_ARGS="--installpath /tmp/pr15007" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_15007 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9870

Test results coming soon (I hope)...

- notification for comment with ID 1361513967 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/cb4d6f4754787c34c12602ca9a505b22 for a full test report.

@boegel boegel modified the milestones: 4.8.0, release after 4.8.0 Jul 6, 2023
@boegel boegel removed this from the 4.8.1 milestone Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clang-9.0.1-GCCcore-8.3.0.eb fails to install
4 participants