-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{vis}[GCCcore/10.2.0] PyQt5 v5.15.1 w/ Python 3.8.6 #11563
{vis}[GCCcore/10.2.0] PyQt5 v5.15.1 w/ Python 3.8.6 #11563
Conversation
depends on @boegel Trying to build this I get some problems;
|
This comment has been minimized.
This comment has been minimized.
Test report by @boegel |
Test report by @zao |
@zao Share the build logs (perhaps both for Qt5 and PyQt5?) so that I can try to spot where it goes wrong for us? |
Test report by @Micket |
This builds for me on centos 8, but fails on centos 7. I found https://wiki.qt.io/Qt_5.15.0_Known_Issues#OpenSSL whish says that Qt 5.15.0 requires OpenSSL 1.1.1. Based on this I am trying a build of Qt 5.15.1 where I have added OpenSSL 1.1.1h as a dep. Then I'll try building PyQt5. |
The errors doesn't really hint towards that, but, worth a shot. I'll try with the openssl11 package under CentOS7 to see if that helps. |
@Micket Packed for size, Qt one is a juicy 120 MiB: |
Test report by @branfosj |
Yes, sorry - there is an unexplained jump in my logic. I compared the logs of the two builds and noticed the OpenSSL difference. centos 8:
centos 7
I also searched for |
Test report by @branfosj Built with Qt5 that has OpenSSL 1.1.1h as a dep. |
So, installing openssl11 rpm wasn't a good option. Still need to add custom link flags to Qt, so, problably just as well to add it via EB.. I also looked into the possibility of just turning off this one component, but, looks like it's the entire Qt Network module in that case (unless one goes into patching stuff, probably). I kind of wanted to avoid this outcome since there are some painful conflicts that occur when you start linking different applications that use. I went down that rabbit hole trying to get some r-plugin linked with a newer openssl on CentOS6, and it just ended with having to rebuilt everything and att the OpenSSL dep everywhere. I wonder if we can make Qt5 statically link it and leave it out as a dep. |
Isn't that a security issue? |
Test report by @Micket |
…asyconfigs into 20201022131119_new_pr_PyQt55151
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@boegelbot please test @ generoso |
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... - notification for comment with ID 735694240 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot |
Test report by @verdurin |
Test report by @migueldiascosta |
Going in, thanks @Micket! |
(created using
eb --new-pr
)