Skip to content

Commit

Permalink
remove exception for using dummy toolchain in EasyBuild easyconfigs
Browse files Browse the repository at this point in the history
  • Loading branch information
boegel committed Mar 13, 2022
1 parent 98e0d74 commit ff80fa2
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions test/easyconfigs/easyconfigs.py
Original file line number Diff line number Diff line change
Expand Up @@ -1214,11 +1214,9 @@ def template_easyconfig_test(self, spec):
self.assertTrue(ec['version'], app.version)

# make sure that deprecated 'dummy' toolchain is no longer used, should use 'system' toolchain instead
# but give recent EasyBuild easyconfigs special treatment to avoid breaking "eb --install-latest-eb-release"
ec_fn = os.path.basename(spec)
if not (ec_fn == 'EasyBuild-3.9.4.eb' or ec_fn.startswith('EasyBuild-4.')):
error_msg_tmpl = "%s should use 'system' toolchain rather than deprecated 'dummy' toolchain"
self.assertFalse(ec['toolchain']['name'] == 'dummy', error_msg_tmpl % os.path.basename(spec))
error_msg_tmpl = "%s should use 'system' toolchain rather than deprecated 'dummy' toolchain"
self.assertFalse(ec['toolchain']['name'] == 'dummy', error_msg_tmpl % os.path.basename(spec))

# make sure that $root is not used, since it is not compatible with module files in Lua syntax
res = re.findall(r'.*\$root.*', ec.rawtxt, re.M)
Expand Down

0 comments on commit ff80fa2

Please sign in to comment.