use find_flexlm_license function in IntelBase generic easyblock #839
Conversation
|
@wpoely86: please review? |
|
Easyblocks unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1710/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
| @@ -44,7 +44,7 @@ | |||
| from easybuild.framework.easyblock import EasyBlock | |||
| from easybuild.framework.easyconfig import CUSTOM | |||
| from easybuild.tools.build_log import EasyBuildError | |||
| from easybuild.tools.filetools import read_file | |||
| from easybuild.tools.filetools import find_flexlm_license, read_file | |||
There was a problem hiding this comment.
I think you don't really need read_file
There was a problem hiding this comment.
Still needed, in parse_components_list
|
👍 |
|
Jenkins: test this please |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1754/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
|
||
| self.license_file = os.pathsep.join(lic_specs) | ||
| self.cfg['license_file'] = self.license_file |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1797/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
use find_flexlm_license function in IntelBase generic easyblock
requires
easybuilders/easybuild-framework#1633see discussion in #837 (cc @damianam, @valtandor)
also fixes #555 (cc @pescobar)