Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Kokkos CPU mapping for LAMMPS >= 2Aug2023 to use icx on Intel Icelake systems #3321

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

steenlysgaard
Copy link
Contributor

I noticed this when installing LAMMPS on our icelake servers and felt it was a typo.

@ocaisa
Copy link
Member

ocaisa commented May 6, 2024

Whether this is supported or not is dependent on the LAMMPS version. The correct place to make the update is within

https://github.com/easybuilders/easybuild-easyblocks/blob/develop/easybuild/easyblocks/l/lammps.py#L228

@boegel boegel added this to the 4.x milestone Aug 28, 2024
@boegel boegel added the bug fix label Aug 28, 2024
@boegel
Copy link
Member

boegel commented Aug 28, 2024

@steenlysgaard Are you planning to follow up on this?

@steenlysgaard
Copy link
Contributor Author

@boegel I have done the change as @ocaisa suggested.

@steenlysgaard
Copy link
Contributor Author

I found the relevant LAMMPS version by looking at this file https://github.com/lammps/lammps/blob/stable_2Aug2023/lib/kokkos/generate_makefile.bash#L182 for different LAMMPS releases

@boegel
Copy link
Member

boegel commented Oct 8, 2024

@casparvl Can you submit a test report for this using LAMMPS-29Aug2024-foss-2023b-kokkos.eb on your Icelake system?

@boegel
Copy link
Member

boegel commented Oct 8, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="LAMMPS-29Aug2024-foss-2023b-kokkos.eb"

@boegel boegel changed the title In kokkos build in LAMMPS - use icx when detecting icelake update Kokkos CPU mapping for LAMMPS >= 2Aug2023 to use icx on Intel Icelake systems Oct 8, 2024
@boegelbot
Copy link

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=3321 EB_ARGS="LAMMPS-29Aug2024-foss-2023b-kokkos.eb" EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_3321 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5031

Test results coming soon (I hope)...

- notification for comment with ID 2400686279 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS LAMMPS-29Aug2024-foss-2023b-kokkos.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/6634276ac668587383497021ee4ff0f8 for a full test report.

@laraPPr
Copy link
Contributor

laraPPr commented Oct 18, 2024

Succesfull build on IceLake See easybuilders/easybuild-easyconfigs#21436 (comment)
And used the correct Kokkos package:

== Determined cpu arch: ICX
== Using Kokkos package with arch: CPU - ICX, GPU - None

Copy link
Contributor

@laraPPr laraPPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laraPPr laraPPr merged commit 5838f1d into easybuilders:develop Oct 18, 2024
41 checks passed
@laraPPr laraPPr modified the milestones: 4.x, release after 4.9.4 Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants