Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sanity check in OpenMPI easyblock to support OpenMPI v5.0.0 #2709

Merged

Conversation

robert-mijakovic
Copy link

(created using eb --new-pr)

@boegel boegel changed the title WIP: OpenMPI 5.0.0 support update sanity check in OpenMPI easyblock to support OpenMPI v5.0.0 Apr 27, 2022
easybuild/easyblocks/o/openmpi.py Outdated Show resolved Hide resolved
Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I should request changes.

We can't reasonably expect people to run prterun instead of mpirun, so mpirun must be somewhere, and there are are some issues on Open MPI's repo about mpirun so it hasn't disappeared.

@boegel boegel added the update label May 3, 2022
@boegel boegel added this to the next release (4.5.5?) milestone May 3, 2022
@boegel
Copy link
Member

boegel commented May 3, 2022

sorry I should request changes.

We can't reasonably expect people to run prterun instead of mpirun, so mpirun must be somewhere, and there are are some issues on Open MPI's repo about mpirun so it hasn't disappeared.

I remember soemthing about mpirun going away and being replaced by prterun, so maybe they did indeed remove it in the end?
Surely this is mentioned in the (draft) OpenMPI v5.0.0 release notes if that's indeed the case...

@robert-mijakovic
Copy link
Author

@boegel @bartoldeman The issue is addressed.

@boegel
Copy link
Member

boegel commented May 25, 2022

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS OpenMPI-3.1.4-GCC-8.3.0.eb
  • SUCCESS OpenMPI-4.0.3-GCC-9.3.0.eb
  • SUCCESS OpenMPI-4.0.5-GCC-10.2.0.eb
  • SUCCESS OpenMPI-4.1.1-GCC-10.3.0.eb
  • SUCCESS OpenMPI-4.1.1-GCC-11.2.0.eb

Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3106.skitty.os - Linux RHEL 8.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/0e8b3b88ced44ebca8fa4329e515c795 for a full test report.

@boegel boegel dismissed bartoldeman’s stale review June 4, 2022 19:17

requested change made

@boegel boegel merged commit 3cb9146 into easybuilders:develop Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants