Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for statically linking Bazel #2272

Closed
wants to merge 5 commits into from

Conversation

edmondac
Copy link
Contributor

@edmondac edmondac commented Dec 7, 2020

Static Bazel changes cherry-picked from #2262

@Flamefire
Copy link
Contributor

Flamefire commented Dec 7, 2020

Tested this and seems to work. Another approach might be to use the (recently created) upstream patch: https://github.com/bazelbuild/bazel/pull/12651/files
Maybe using --action_env=LD_LIBRARY_PATH to the build process of the dependency would also work. Testing that now so we at least know our options.
Edit: No doesn't work. So either patch or this.

@boegel boegel changed the title Static bazel add support for statically linking Bazel Dec 7, 2020
@boegel boegel added this to the 4.4.0 milestone Dec 7, 2020
@Flamefire
Copy link
Contributor

Currently testing the official patch. Is there a preference for when there is a known patch for the next version but many versions require the patch? I.e. still do the workaround in the EasyBlock or add the patch to prior ECs?
Note that the change in this PR is opt-in so ECs would need to be changed too.

@boegel
Copy link
Member

boegel commented Dec 31, 2020

superseded by #2285 (at least, once the static linking is also done opt-in there like it is here)

@boegel boegel closed this in #2285 Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants