-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update config.guess for all R packages #1949
Conversation
36755a4
to
2cb750c
Compare
I've tried testing this, but there are too many things in the way. E.g. we need easybuilders/easybuild-easyconfigs#9694 merging. Also older R version have checksum failures (as expected) and I'm not able to go through and fix them right now. Saying that, it does seem to work for the bits that did build! |
f893d31
to
86d0a06
Compare
86d0a06
to
ba26246
Compare
@boegel Updated this with the following changes worth verifying:
Pending approval: Remove arguments of |
8ce05a6
to
54691d1
Compare
@boegel Test results in easybuilders/easybuild-easyconfigs#9830 show that this works and fixes the issue on Power. What I like to do before merging this is to remove arguments of obtain_config_guess, see #1949 (comment) |
Factor out the check and obtain config.guess from ConfigureMake into free functions to be able to use them inside the rpackage EB. Change the workflow for R packages to always extract which is more in line with the regular workflow for other EasyConfigs. This then allows to search for config.guess files to replace by the downloaded version contained within EasyBuild.
…obtain_file Verify downloaded AND existing file redownloading if required Honor force_download option
54691d1
to
11b6db2
Compare
…n_config_guess - search_source_paths was totally ignored (Bug) - download_source_path was hard to use as final location was not obvious - not used by anything in EasyBuild itself Throw readable error when any argument is passed to make future maintenance easier and avoid users running into the bug.
11b6db2
to
8af677b
Compare
I did the change I proposed now for easier assesment in 8af677b I even found that using the source-* argument didn't work at all which is another point for the change. The current implementation is to raise an error that those arguments were removed. This caters for external users using that function. The alternative is to simply remove the arguments and let Python handle it by throwing a (IIRC) Not using deprecation on purpose as the implementation contained at least 1 bug. So removing it is safer IMO. |
@boegel ping again. This has been tested successfully in easybuilders/easybuild-easyconfigs#10531 multiple times. |
… ConfigureMake.obtain_config_guess, but deprecate their use
restore 'download_source_path' and 'search_source_paths' argument for ConfigureMake.obtain_config_guess, but deprecate their use
I've tested this extensively by installing |
Factor out the check and obtain config.guess from ConfigureMake into free functions to be able to use them inside the rpackage EB.
Change the workflow for R packages to always extract which is more in line with the regular workflow for other EasyConfigs.
This then allows to search for config.guess files to replace by the downloaded version contained within EasyBuild.
This is an alternate, more complete approach to #1938
I tested some random R based ECs including the underlying R successfully: rgdal-1.4-8-foss-2019b-R-3.6.2.eb ncdf4-1.16.1-foss-2019a-R-3.6.0.eb lavaan-0.6-4.1433-foss-2019a-R-3.6.0.eb
Requires: