Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client_secret (if defined) is passed as a parameter to authorization URL #26

Open
jasoncpatton opened this issue Dec 17, 2018 · 0 comments

Comments

@jasoncpatton
Copy link

If a client has set a client_secret in their ClientConfig object, when getAuthorizerUrl() builds the authorization URL from clientConfig->getParams(), the client_secret is added to the parameter list. This exposes the client_secret to users of the client when they are sent to an OAuth2 authorization endpoint. The client_secret should only be added to a request to an OAuth2 token endpoint.

protected function getAuthorizeUrl()
{
$params = [
'response_type' => 'code',
'state' => $this->stateStore->getState(),
] + $this->clientConfig->getParams();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant