Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hillshade's keyword arguments to azimuth and altitude? #436

Closed
sgillies opened this issue Oct 24, 2019 · 2 comments
Closed

Change hillshade's keyword arguments to azimuth and altitude? #436

sgillies opened this issue Oct 24, 2019 · 2 comments
Assignees

Comments

@sgillies
Copy link
Contributor

Context: pyOpenSci/software-submission#3.

Could the keyword arguments of

def hillshade(arr, azimuth=30, angle_altitude=30):
be made more consistent by changing them to azimuth and altitude and dropping the angle_ prefix for the latter?

@lwasser
Copy link

lwasser commented Oct 24, 2019

totally @sgillies we can do that!! i'm going to allocate some time today and tomorrow to work on these issues!!

@lwasser
Copy link

lwasser commented Oct 25, 2019

this has been implemented @sgillies !! closing but please reopen if our implementation is not what you intended!! #438 addresses this.

@lwasser lwasser closed this as completed Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants