[Bug] readonly kwarg not respected

[TomNicholas]

from @abarciauskas-bgse in zarr-developers/VirtualiZarr#272 (comment)

It doesn't look like the read_only property is working as I would expect it to in the latest released version of icechunk (0.1.0a4):

from icechunk import IcechunkStore, StorageConfig
config = StorageConfig.filesystem("local")

store = IcechunkStore.create(storage=config, read_only=False)
print(store.mode)
# AccessMode(str='w', readonly=False, overwrite=True, create=True, update=False)

store = IcechunkStore.open_existing(storage=config)
print(store.mode) 
# AccessMode(str='r', readonly=True, overwrite=False, create=False, update=False)

store = IcechunkStore.open_existing(storage=config, read_only=False) 
print(store.mode)
# AccessMode(str='r', readonly=True, overwrite=False, create=False, update=False)

store = IcechunkStore.open_existing(storage=config, mode="a")
print(store.mode)
# AccessMode(str='a', readonly=False, overwrite=False, create=True, update=True)

store = IcechunkStore.open_existing(storage=config, mode="w")
print(store.mode)
# AccessMode(str=w', readonly=False, overwrite=True, create=True, update=False)

store = IcechunkStore.open_existing(storage=config, update=True)
print(store.mode)
# AccessMode(str='r', readonly=True, overwrite=False, create=False, update=False)

I note from the above that the only way to open the icechunk store in append mode is still using mode="a"

[mpiannucci]

The latest version of icechunk still uses mode. The main branch uses read_only. We are not releasing the next version until #357 is merged.

[mpiannucci]

This should be fixed with version a5