Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PlatformIO builder script + docs #612

Closed
maxgerhardt opened this issue Jun 7, 2022 · 9 comments · Fixed by #633
Closed

Update PlatformIO builder script + docs #612

maxgerhardt opened this issue Jun 7, 2022 · 9 comments · Fixed by #633
Labels
platformio Platform.IO support

Comments

@maxgerhardt
Copy link
Contributor

maxgerhardt commented Jun 7, 2022

Commits

require an update of docs in regards to

  • update toolchain link downloads for the new version
  • how to activate stack protector

require an update of the builder script in regards to

  • correctly linking against -lstdc++ or -lstdc++-exc depending on whether exceptions are enabled (-fexceptions found in build flags)

(reminder for me later)

@earlephilhower
Copy link
Owner

Argh, sorry for breaking your build. I need to do a Platform.IO job as part of CI. :(

@maxgerhardt
Copy link
Contributor Author

Pretty sure it did not break the build (e.g., -lstdc++ is sitll linked against), we just need to expose the new features to PlatformIO projects too by expanding the builder script.

@earlephilhower earlephilhower added the platformio Platform.IO support label Jun 8, 2022
@ivankravets
Copy link
Contributor

Hi @maxgerhardt and @earlephilhower,

We have received 35 packages for review in the PlatformIO registry. What is the further fate of these packages?

platformio/platform-raspberrypi#13 - Could you provide a PR with support for this core?

Thanks!

@maxgerhardt
Copy link
Contributor Author

Ideally we'd want to have the pico-toolchain, Raspberrypi's tool-openocd version and framework-arduinopico in the registry, then I can reference stable versions in https://github.com/maxgerhardt/platform-raspberrypi and create the PR.

@ivankravets
Copy link
Contributor

ivankravets commented Jun 9, 2022

All packages are approved => https://registry.platformio.org/search?q=owner%3Aearlephilhower&t=tool

Please tell us which packages are not required, we will remove them to keep the registry clean.

@ivankravets
Copy link
Contributor

Do we need a custom ARM toolchain and OpenOCD?

@maxgerhardt
Copy link
Contributor Author

maxgerhardt commented Jun 9, 2022

Hmm I think I had problems with the tool-openocd-raspberrypi version tha PlatformIO had (1 year old) when trying PicoProbe etc. support, so a newer build is needed, as provided by https://github.com/earlephilhower/pico-quick-toolchain/releases.

And as far as I understand it, this core builds on custom configuration + features of the ARM toolchain, e.g. with exception code etc. (linking against stdc++-exc if exceptions are enabled etc), see e.g. here.

All packages are approved

Great, I'll see if I can work with that. As detailed in this issue, we probably need a small builder script fixup and release 2.0.4 to get full / equal build options support with the Arduino IDE.

@ivankravets
Copy link
Contributor

Thanks for the provided information. We would be thankful for the PR. I've just done a quick look at your fork and it looks good. The only note is to use env.Exit(1) in SCons scripts where you need to stop the building process.

@maxgerhardt
Copy link
Contributor Author

maxgerhardt commented Jun 9, 2022

@ivankravets PR created for platform-raspberrypi per above, PR for PlatformIO docs and here builder script + doc update here will follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platformio Platform.IO support
Projects
None yet
3 participants