From b1b1ae7492dda69cd5004fd88e45dcdf7cf4c124 Mon Sep 17 00:00:00 2001 From: LN <91385411+Ln11211@users.noreply.github.com> Date: Mon, 24 Oct 2022 21:16:08 +0530 Subject: [PATCH] [core-Feature] Set deadlines to zero (#493) * Update config.go Set the default values to 0 Signed-off-by: LN Signed-off-by: Ln11211 <91385411+Ln11211@users.noreply.github.com> * disable k8s controller-runtime manager metrics server (#492) * setting MetricsBindAddress to 0 to disable controller-runtime manager metrics server Signed-off-by: Daniel Rammer * and now in the webhook Signed-off-by: Daniel Rammer Signed-off-by: Daniel Rammer Signed-off-by: Ln11211 <91385411+Ln11211@users.noreply.github.com> * fix: Add servicename in certs (#491) Before: A hardcoded string was used for setting the secret namespace After: The value for the secret namespace for settings is grabbed dynamically. Signed-off-by: Francisco J. Solis Signed-off-by: Francisco J. Solis Co-authored-by: Dan Rammer Signed-off-by: Ln11211 <91385411+Ln11211@users.noreply.github.com> * Update config.go Removed DefaultDeadlines Signed-off-by: Ln11211 <91385411+Ln11211@users.noreply.github.com> Signed-off-by: LN Signed-off-by: Ln11211 <91385411+Ln11211@users.noreply.github.com> Signed-off-by: Daniel Rammer Signed-off-by: Francisco J. Solis Co-authored-by: Dan Rammer Co-authored-by: Francisco J. Solis --- pkg/controller/config/config.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/pkg/controller/config/config.go b/pkg/controller/config/config.go index 20e3f90d45..0129574727 100644 --- a/pkg/controller/config/config.go +++ b/pkg/controller/config/config.go @@ -90,11 +90,6 @@ var ( RetryPeriod: config.Duration{Duration: time.Second * 2}, }, NodeConfig: NodeConfig{ - DefaultDeadlines: DefaultDeadlines{ - DefaultNodeExecutionDeadline: config.Duration{Duration: time.Hour * 48}, - DefaultNodeActiveDeadline: config.Duration{Duration: time.Hour * 48}, - DefaultWorkflowActiveDeadline: config.Duration{Duration: time.Hour * 72}, - }, MaxNodeRetriesOnSystemFailures: 3, InterruptibleFailureThreshold: 1, },