From 860ebfb22509d0acb56a91b7a3a943c588f905ea Mon Sep 17 00:00:00 2001 From: pmahindrakar-oss Date: Tue, 5 Apr 2022 21:16:19 +0530 Subject: [PATCH] Removed check on kickofftimearg (#388) Signed-off-by: Prafulla Mahindrakar --- flyteadmin/pkg/manager/impl/launch_plan_manager.go | 3 --- flyteadmin/pkg/manager/impl/launch_plan_manager_test.go | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/flyteadmin/pkg/manager/impl/launch_plan_manager.go b/flyteadmin/pkg/manager/impl/launch_plan_manager.go index 2f1cc68202..f2192b701c 100644 --- a/flyteadmin/pkg/manager/impl/launch_plan_manager.go +++ b/flyteadmin/pkg/manager/impl/launch_plan_manager.go @@ -145,9 +145,6 @@ func isScheduleEmpty(launchPlanSpec admin.LaunchPlanSpec) bool { if schedule.GetCronSchedule() != nil && len(schedule.GetCronSchedule().Schedule) != 0 { return false } - if len(schedule.GetKickoffTimeInputArg()) != 0 { - return false - } if len(schedule.GetCronExpression()) != 0 { return false } diff --git a/flyteadmin/pkg/manager/impl/launch_plan_manager_test.go b/flyteadmin/pkg/manager/impl/launch_plan_manager_test.go index 4e0b79ab24..61b5db80bb 100644 --- a/flyteadmin/pkg/manager/impl/launch_plan_manager_test.go +++ b/flyteadmin/pkg/manager/impl/launch_plan_manager_test.go @@ -1407,6 +1407,6 @@ func TestIsScheduleEmpty(t *testing.T) { }, }, } - assert.False(t, isScheduleEmpty(sp)) + assert.True(t, isScheduleEmpty(sp)) }) }