From 37469ac151b75a2dfda1f6a874af443e1d131744 Mon Sep 17 00:00:00 2001 From: Haytham AbuelFutuh Date: Tue, 19 May 2020 14:54:10 -0700 Subject: [PATCH] Mark Hive and Presto query failures as Retryable to allow Propeller to decide the behavior (#91) * Mark Hive Query Failures as retryable * Mark Presto Query Failures as retryable --- flyteplugins/go/tasks/plugins/hive/execution_state.go | 2 +- flyteplugins/go/tasks/plugins/presto/execution_state.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/flyteplugins/go/tasks/plugins/hive/execution_state.go b/flyteplugins/go/tasks/plugins/hive/execution_state.go index c0caa5c15a..bc7b13603c 100644 --- a/flyteplugins/go/tasks/plugins/hive/execution_state.go +++ b/flyteplugins/go/tasks/plugins/hive/execution_state.go @@ -116,7 +116,7 @@ func MapExecutionStateToPhaseInfo(state ExecutionState, quboleClient client.Qubo phaseInfo = core.PhaseInfoSuccess(ConstructTaskInfo(state)) case PhaseQueryFailed: - phaseInfo = core.PhaseInfoFailure(errors.DownstreamSystemError, "Query failed", ConstructTaskInfo(state)) + phaseInfo = core.PhaseInfoRetryableFailure(errors.DownstreamSystemError, "Query failed", ConstructTaskInfo(state)) } return phaseInfo diff --git a/flyteplugins/go/tasks/plugins/presto/execution_state.go b/flyteplugins/go/tasks/plugins/presto/execution_state.go index 8e917cef88..7cfb647b84 100644 --- a/flyteplugins/go/tasks/plugins/presto/execution_state.go +++ b/flyteplugins/go/tasks/plugins/presto/execution_state.go @@ -495,7 +495,7 @@ func MapExecutionStateToPhaseInfo(state ExecutionState) core.PhaseInfo { phaseInfo = core.PhaseInfoSuccess(ConstructTaskInfo(state)) } case PhaseQueryFailed: - phaseInfo = core.PhaseInfoFailure(errors.DownstreamSystemError, "Query failed", ConstructTaskInfo(state)) + phaseInfo = core.PhaseInfoRetryableFailure(errors.DownstreamSystemError, "Query failed", ConstructTaskInfo(state)) } return phaseInfo