Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction model missing attributes in phpdoc #22

Open
OldStarchy opened this issue Sep 30, 2021 · 1 comment
Open

Transaction model missing attributes in phpdoc #22

OldStarchy opened this issue Sep 30, 2021 · 1 comment

Comments

@OldStarchy
Copy link

OldStarchy commented Sep 30, 2021

There are a bunch of attributes on the Transaction model missing from the phpdoc, namely TransactionStatus referenced by the docs and used in the readme example.

This left me confused for a while before I decided to check the code to make sure it wasn't just a typing problem; it wouldn't be the first time that the documentation for an API is out of sync with either the client library or the implementation (or both).

The following phpdoc properties are missing

Address
AuthorisationCode
BeagleEmail
BeaglePhone
BeagleScore
BeagleVerification
Captured
CustomerIP
CustomerNote
CustomerReadOnly
CustomView
CVN
Email
HeaderText
InvoiceReference
Language
LogoUrl
Mobile
Phone
ProcessingDetails
ResponseCode
ResponseMessage
Status
Total
TotalAmount
TransactionID
TransactionStatus
Verification
VerifyCustomerEmail
VerifyCustomerPhone

Also, AuthorisationCode is listed in $fillable twice.

@OldStarchy
Copy link
Author

(Semi) related #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant