Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to gradle 7.x #196

Closed
jyeonjyan opened this issue Jan 27, 2022 · 2 comments
Closed

Upgrade to gradle 7.x #196

jyeonjyan opened this issue Jan 27, 2022 · 2 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@jyeonjyan
Copy link

Hello.

While smoothly following Getting started
I get an error Could not find method testCompile() for arguments and make a request.

In a way, this is a very simple error.

However, since it is an open source project,
I respectfully request it because I thought it would be good to always keep the latest version of README.

As of Gradle 7, the testCompile method has been removed.
Screen Shot 2022-01-28 at 1 46 37 AM

It would be appreciated if you correct the 2.2/dependencies/testCompile() configuration with testImplementation().

testImplementation('com.epages:restdocs-api-spec-mockmvc:0.15.1') //2.2 | works with Gradle 7 version

Thank you for developing a great product 🙂

@ozscheyge ozscheyge added the good first issue Good for newcomers label Feb 4, 2022
@ozscheyge
Copy link
Contributor

Hey @jyeonjyan ,

that's true and thanks for pointing it out! Looks like, you managed anyway. :)

We aren't explicit on the gradle version we use for the example, we just assumed the same as the gradle wrapper included in this project, which is basically a year old ( https://gradle.org/releases/ ), but still works fine.

The solution space:

  • Update gradle wrapper to 7.x, update the example
  • Be explicit about the gradle version in the example
  • Maybe, provide examples for each gradle version

@jmewes jmewes added good first issue Good for newcomers and removed good first issue Good for newcomers labels Feb 14, 2022
@ozscheyge ozscheyge changed the title Request to apply changes in gradle 7.x version Upgrade to gradle 7.x Nov 28, 2022
@ozscheyge ozscheyge self-assigned this Nov 28, 2022
@ozscheyge
Copy link
Contributor

This is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants