Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert float32 input #36

Closed
wants to merge 4 commits into from
Closed

Convert float32 input #36

wants to merge 4 commits into from

Conversation

ruoshuili-cn
Copy link

close #35

@ruoshuili-cn
Update rescue.ipynb
17d0328 
Convert input_trainval data type from object to float
@ruoshuili-cn
Reconciliation of capital and lowercase letters
bf06d1e 
1. In data_preprocessing.py: capitalize initials of "_forecast_error" or "net_load_forecast_error" to be consistent with visualization parameters in rescue.ipynb.
2. In UI: capitalize Category column (column H) in "Timeseries Attributes" tab to be consistent with visualization parameters in rescue.ipynb
@ruoshuili-cn
Revert "Update rescue.ipynb"
6887338 
This reverts commit 17d0328.
@ruoshuili-cn
Update data_preprocessing_into_inputs.py
6e5976a 
Convert trainval/test/infer data to float
YuchiSun
YuchiSun reviewed Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@YuchiSun YuchiSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first PR. One small point is that I think you actually reverted the changes you made regarding casting to float 32. So that defeated the purpose. The other content of this PR (capaital letter for net_load) has been incorporated in another update

@YuchiSun YuchiSun closed this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuchiSun YuchiSun YuchiSun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert data into float32 prior to writing to hard drive
2 participants
@ruoshuili-cn @YuchiSun