Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/2430 #2460

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Issues/2430 #2460

wants to merge 6 commits into from

Conversation

KS-HTK
Copy link
Collaborator

@KS-HTK KS-HTK commented Nov 25, 2024

closes #2430

hkoertge added 4 commits November 25, 2024 11:42
updated for geojson support
27447aa
removed ga wrapper function for better code quality
d8486f6
fixed formatting issues
26dbbb0 
switched to f-strings instead of % notation
added some type hints and docstrings
rewrote calculation to remove redundant calls
ef62aa2 
renamed vars to small letters as per python naming convention
@KS-HTK KS-HTK requested a review from mfranz13 November 25, 2024 11:01
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.62348% with 201 lines in your changes missing coverage. Please review.

Project coverage is 76.26%. Comparing base (17e19e1) to head (f97d482).

Files with missing lines Patch % Lines
...ower/converter/powerfactory/pp_import_functions.py 7.18% 155 Missing ⚠️
pandapower/protection/utility_functions.py 42.50% 46 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2460      +/-   ##
===========================================
+ Coverage    76.04%   76.26%   +0.22%     
===========================================
  Files          282      282              
  Lines        33037    32946      -91     
===========================================
+ Hits         25123    25127       +4     
+ Misses        7914     7819      -95

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hkoertge and others added 2 commits November 26, 2024 11:35
fixed us of net.bus_geodata and net.line_geodata
ce45bd0 
reformatted file
simplified some functions
renamed some capitalized variables
@KS-HTK
Merge branch 'develop' into issues/2430
f97d482
@KS-HTK KS-HTK requested review from mrifraunhofer and removed request for mfranz13 November 27, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrifraunhofer mrifraunhofer Awaiting requested review from mrifraunhofer

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] replace old net.bus_geodata, net.line_geodata by up-to-date net.bus.geo, net.line.geo
1 participant
@KS-HTK