Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the modal logic #1851

Closed
florian-str opened this issue Jan 16, 2023 · 1 comment · Fixed by #1985
Closed

Update the modal logic #1851

florian-str opened this issue Jan 16, 2023 · 1 comment · Fixed by #1985
Assignees
Labels
[C] Frontend Focuses on frontend implementation [P] Minor Minor priority [T] Refactoring Existing parts should become faster, more readable, or in any other way better.

Comments

@florian-str
Copy link
Collaborator

florian-str commented Jan 16, 2023

The modals in the current form can be difficult to use or debug.
Part of the issue is that the function names used for controlling the modals are created in the django-template by embedding the modal-id as a template-variable in the function signature.
This makes it difficult to find the references as they only exist at runtime.
As the django-based creation is also applied to the methods acting upon the user decision, it might require some workarounds or duplicate code if that particular use case does not fit the default flow.

@niklasmohrin
Copy link
Member

Related: #1837 (comment)

@richardebeling richardebeling added [C] Frontend Focuses on frontend implementation [T] Refactoring Existing parts should become faster, more readable, or in any other way better. labels Jan 16, 2023
@janno42 janno42 added the [P] Minor Minor priority label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Frontend Focuses on frontend implementation [P] Minor Minor priority [T] Refactoring Existing parts should become faster, more readable, or in any other way better.
Development

Successfully merging a pull request may close this issue.

4 participants