Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

fix(nx-distributed-task): undefined args are not filtered out #52

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

ronnetzer
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@ronnetzer ronnetzer requested a review from eliraneliassy July 18, 2022 08:43
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #52 (b5d1697) into main (57441b6) will increase coverage by 1.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   86.61%   87.92%   +1.31%     
==========================================
  Files          15       15              
  Lines         381      381              
  Branches       55       55              
==========================================
+ Hits          330      335       +5     
+ Misses         48       43       -5     
  Partials        3        3              
Flag Coverage Δ *Carryforward flag
nx-affected-matrix 95.91% <ø> (ø) Carriedforward from 57441b6
nx-distributed-task 100.00% <100.00%> (+4.80%) ⬆️
utils 80.70% <ø> (ø) Carriedforward from 57441b6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/nx-distributed-task/src/app/nx.ts 100.00% <100.00%> (+11.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec6b3d...b5d1697. Read the comment docs.

@eliraneliassy eliraneliassy merged commit 353e717 into main Jul 18, 2022
@eliraneliassy eliraneliassy deleted the bugfix/undefind-args-not-filtered branch July 18, 2022 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants