Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

fix(nx-distributed-task): running NX command is not working with pnpm #44

Merged
merged 1 commit into from
Mar 20, 2022
Merged

fix(nx-distributed-task): running NX command is not working with pnpm #44

merged 1 commit into from
Mar 20, 2022

Conversation

robinpellegrims
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: fixes #40

What is the new behavior?

-p @nrwl/cli arguments are only added for npm/yarn and no longer for pnpm

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #44 (13b4906) into main (4df7758) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   88.42%   88.58%   +0.15%     
==========================================
  Files          15       15              
  Lines         363      368       +5     
  Branches       51       52       +1     
==========================================
+ Hits          321      326       +5     
  Misses         39       39              
  Partials        3        3              
Flag Coverage Δ *Carryforward flag
nx-affected-matrix 95.91% <ø> (ø) Carriedforward from 4df7758
nx-distributed-task 100.00% <100.00%> (ø)
utils 82.14% <ø> (ø) Carriedforward from 4df7758

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/nx-distributed-task/src/app/nx.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31e74e...13b4906. Read the comment docs.

@ronnetzer ronnetzer merged commit d569434 into e-square-io:main Mar 20, 2022
@robinpellegrims robinpellegrims deleted the bugfix/not-working-with-pnpm branch March 21, 2022 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Running NX command is not working with pnpm
2 participants