Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

fix: cant get task configuration when resolving customHasher #41

Merged
merged 5 commits into from
Mar 15, 2022

Conversation

ronnetzer
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

cant resolve custom hasher due to nx internals using require directly.

Issue Number: N/A

What is the new behavior?

will now resolve the custom hasher without throwing the error

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #41 (aaf6e87) into main (53cd2c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files          15       15           
  Lines         362      362           
  Branches       50       50           
=======================================
  Hits          319      319           
  Misses         39       39           
  Partials        4        4           
Flag Coverage Δ
nx-affected-matrix 95.91% <ø> (ø)
nx-distributed-task 100.00% <ø> (ø)
utils 81.61% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b07bf3...aaf6e87. Read the comment docs.

@ronnetzer ronnetzer merged commit 9596455 into main Mar 15, 2022
@ronnetzer ronnetzer deleted the bugfix/cant-find-task-configuration branch March 15, 2022 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant