Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

feat: use nx devkit #33

Merged
merged 13 commits into from
Mar 6, 2022
Merged

feat: use nx devkit #33

merged 13 commits into from
Mar 6, 2022

Conversation

ronnetzer
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: fixes #16

What is the new behavior?

usage of nx devkit and internals instead of using exec and expect that the user will do npm ci before using the action

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@nx-cloud
Copy link

nx-cloud bot commented Mar 3, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 00e4da6. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #33 (00e4da6) into main (cdf3de0) will increase coverage by 0.28%.
The diff coverage is 88.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   86.24%   86.53%   +0.28%     
==========================================
  Files          13       15       +2     
  Lines         349      349              
  Branches       51       49       -2     
==========================================
+ Hits          301      302       +1     
  Misses         38       38              
+ Partials       10        9       -1     
Flag Coverage Δ
nx-affected-matrix 95.91% <90.47%> (-1.86%) ⬇️
nx-distributed-task 90.36% <90.90%> (-1.54%) ⬇️
utils 82.94% <73.33%> (-0.58%) ⬇️
Impacted Files Coverage Δ
packages/nx-affected-matrix/src/app/inputs.ts 100.00% <ø> (ø)
packages/nx-distributed-task/src/app/inputs.ts 80.00% <ø> (ø)
packages/utils/src/lib/fs.ts 25.00% <0.00%> (ø)
packages/utils/src/lib/inputs.ts 66.66% <66.66%> (+1.14%) ⬆️
packages/nx-distributed-task/src/app/nx.ts 85.29% <85.29%> (ø)
packages/nx-distributed-task/src/app/upload.ts 88.88% <88.88%> (ø)
...s/nx-affected-matrix/src/app/nx-affected-matrix.ts 97.05% <90.00%> (-0.51%) ⬇️
packages/nx-affected-matrix/src/main.ts 90.90% <90.90%> (ø)
packages/nx-distributed-task/src/app/cache.ts 100.00% <100.00%> (ø)
packages/nx-distributed-task/src/main.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e413ef6...00e4da6. Read the comment docs.

@ronnetzer ronnetzer merged commit 93c39e7 into main Mar 6, 2022
@ronnetzer ronnetzer deleted the feature/use-nx-devkit branch March 6, 2022 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Make it possible to run nx-affected-matrix without npm ci
1 participant