Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

fix(utils): glob error is not handled silently #31

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

ronnetzer
Copy link
Member

@ronnetzer ronnetzer commented Mar 1, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: fixes #9

What is the new behavior?

globbing was moved to be inside try/catch block

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@nx-cloud
Copy link

nx-cloud bot commented Mar 1, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 8b369cd. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@ronnetzer ronnetzer force-pushed the bugfix/artifacts-not-found branch from e5535c4 to 8b369cd Compare March 1, 2022 13:50
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #31 (8b369cd) into main (c52bc3b) will increase coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   86.24%   86.53%   +0.28%     
==========================================
  Files          13       13              
  Lines         349      349              
  Branches       51       51              
==========================================
+ Hits          301      302       +1     
  Misses         38       38              
+ Partials       10        9       -1     
Flag Coverage Δ
nx-affected-matrix 97.77% <ø> (ø)
nx-distributed-task 91.89% <ø> (ø)
utils 83.89% <100.00%> (+0.37%) ⬆️
Impacted Files Coverage Δ
packages/utils/src/lib/artifact.ts 100.00% <100.00%> (ø)
packages/utils/src/lib/fs.ts 29.16% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e874871...8b369cd. Read the comment docs.

@ronnetzer ronnetzer merged commit 4b659cc into main Mar 1, 2022
@ronnetzer ronnetzer deleted the bugfix/artifacts-not-found branch March 1, 2022 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Task fails when artifacts to upload not found
1 participant