-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create the iOS version of the status screen #812
Conversation
- Replace placeholders with appropriate text - Add `scope.setupIOSLocChecks` and `scope.setupIOSFitnessChecks` - For notifications, we re-use the android settings - For background restrictions, we disable them since they don't exist (or at least, are not user controllable) on iOS
- End-to-end implementation of the "check" parts of the interface - Code structure similar to the existing android code for simplicity - checks defined in `TripDiarySensorControlChecks` - interface with the plugin in `SensorControlForegroundDelegate` - interface with the background code to generate error notifications in `SensorControlBackgroundChecker` Testing done: With the UI changes in: e-mission/e-mission-phone@d69f3a5 the plugin -> foreground delegate -> checks pipeline works e-mission/e-mission-phone#812 (comment) TO DO: - Background checks need to be tested - Implement the "fix" methods in addition to the "check" methods
Digging a little deeper:
Why is there such a large margin?
Ah it is because the
Apparently that hardcoded width is large enough on android but not on iOS? |
Setting an explicit % width (90%) for the range seems to fix it, but let's see why we had a hardcoded value to begin with.
Ok, let's go ahead and change it. |
If they are too narrow, they cause the actual footprint to be hidden. There is no known reason why they are an absolute, instead of a relative value. They are only used in this one place, so changing them should not break anything else. So we just change them back to a relative value More details: e-mission#812 (comment) e-mission#812 (comment) e-mission#812 (comment) e-mission#812 (comment)
Making some final wording changes since we don't have any fallbacks. |
For my future reference, if not for others :)
This allows the Spanish and French groups to incorporate the changes as well + Modify some of the text at the same time to make it more clear
For example, after opening the app settings page to change settings and then coming back to the app.
- Bump up overall app version - Also bump up versions for the following plugins: - data collection: bulk of the changes, bump up a full minor version - server sync: move the fitness permission init code into the new permissions module - unified logger: add a new method to generate plugin compatible notifications so we can tell the user when their status is bad and automatically open the page to fix it. - usercache: includes code that calls the local notifications, so needed to change method signature to match the notification state. This pretty much concludes e-mission/e-mission-docs#680
This finally fixes e-mission/e-mission-docs#680 |
scope.setupIOSLocChecks
andscope.setupIOSFitnessChecks
least, are not user controllable) on iOS