Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make qnap check strict mode compatible #704

Merged
merged 2 commits into from
Jul 17, 2023
Merged

make qnap check strict mode compatible #704

merged 2 commits into from
Jul 17, 2023

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Jul 16, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

strict mode failed

@m-1-k-3 m-1-k-3 added the bug Something isn't working label Jul 16, 2023
@m-1-k-3 m-1-k-3 requested a review from BenediktMKuehne July 16, 2023 11:25
BenediktMKuehne
BenediktMKuehne approved these changes Jul 17, 2023
View reviewed changes
modules/P02_firmware_bin_file_check.sh
@@ -144,7 +144,7 @@ fw_bin_detector() {
# we are running binwalk on the file to analyze the output afterwards:
"${BINWALK_BIN[@]}" "$CHECK_FILE" > "$TMP_DIR"/s02_binwalk_output.txt
if [[ -f "$TMP_DIR"/s02_binwalk_output.txt ]]; then
QNAP_ENC_CHECK=$(grep -a -i "qnap encrypted" "$TMP_DIR"/s02_binwalk_output.txt)
QNAP_ENC_CHECK=$(grep -a -i "qnap encrypted" "$TMP_DIR"/s02_binwalk_output.txt || true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love those 😂

@BenediktMKuehne BenediktMKuehne merged commit af37409 into e-m-b-a:master Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenediktMKuehne BenediktMKuehne BenediktMKuehne approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-1-k-3 @BenediktMKuehne