Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download file to subdirectory #236

Open
Jwiggiff opened this issue Jan 2, 2022 · 0 comments · May be fixed by #237
Open

Download file to subdirectory #236

Jwiggiff opened this issue Jan 2, 2022 · 0 comments · May be fixed by #237

Comments

@Jwiggiff
Copy link

Jwiggiff commented Jan 2, 2022

Steps to reproduce

  1. In output name for download, put /subdirectory/file.txt

Expected behaviour

File downloaded to Downloads/subdirectory/file.txt

Actual behaviour

File downloaded to Downloads/subdirectory_file.txt

I believe this is issue is caused by the fix implemented in #221. The sanitization should be so it disallows parent directories (which was the security vulnerability) but allow subdirectories.
@Jwiggiff Jwiggiff linked a pull request Jan 8, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't sanitize subdirectories Jwiggiff/ocdownloader
1 participant
@Jwiggiff