Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from AngularJS #74

Closed
e-alfred opened this issue Nov 22, 2019 · 7 comments · Fixed by #73
Closed

Migrate away from AngularJS #74

e-alfred opened this issue Nov 22, 2019 · 7 comments · Fixed by #73

Comments

@e-alfred
Copy link
Owner

AngularJS is in LTS mode currently and will be deprecated in 2021 after a 3 year period. We should move away from AngularJS to Vue probably at some point in the future.

One possible library would be to use vue-flow as an alternative:

https://github.com/shenron/vue-flow

@JonathanTreffler
Copy link
Collaborator

to Vue

Sounds good

https://github.com/shenron/vue-flow

Is this production ready ?
(0 releases and 24 commits)

@e-alfred
Copy link
Owner Author

It is just one possibility, there is an Angular based version too or even a PHP server:

https://github.com/flowjs/ngx-flow

Best option would be to use only flow.js without any dependencies like Angular and AngularJS as to minimize the amount of problems relying on 3rd party libraries altogether:

https://github.com/flowjs/flow.js

@JonathanTreffler
Copy link
Collaborator

Best option would be to use only flow.js without any dependencies like Angular and AngularJS as to minimize the amount of problems relying on 3rd party libraries altogether:

Do you mean vue.js + flow.js (not the old currently used version) , but no ng-flow or ngx-flow wrapper ?
Because thats what i would prefer.

@e-alfred
Copy link
Owner Author

Do you mean vue.js + flow.js (not the old currently used version) , but no ng-flow or ngx-flow wrapper ?

Pretty much yes, no Angular or AngularJS dependencies at all. Vue.js is pretty much the standard now for Nextcloud apps anyway.

@JonathanTreffler
Copy link
Collaborator

Because we no longer use ng-flow when #73 gets merged it should be pretty easy to migrate to vue.js

@JonathanTreffler
Copy link
Collaborator

The "bug" label should probably be removed from this issue.

@e-alfred e-alfred added enhancement and removed bug labels Dec 2, 2019
@e-alfred e-alfred linked a pull request May 23, 2020 that will close this issue
@e-alfred
Copy link
Owner Author

Fixed by #73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants