From ea865837f88121973ac30d9420f21be262b0a669 Mon Sep 17 00:00:00 2001 From: Chi Ma Date: Sat, 15 Jul 2023 23:14:31 +0700 Subject: [PATCH] chore: upgrade nock@13.3.1 and re-enable test in node@18 for resource-detector-alibaba-cloud (#1581) * chore: upgrade nock@13.3.1 and re-enable test in node@18 for resource-detector-alibaba-cloud * chore: remove --ignore @opentelemetry/resource-detector-alibaba-cloud in tav pipeline --------- Co-authored-by: Haddas Bronfman <85441461+haddasbronfman@users.noreply.github.com> Co-authored-by: Amir Blum --- .github/workflows/test-all-versions.yml | 1 - .github/workflows/unit-test.yml | 1 - .../opentelemetry-resource-detector-alibaba-cloud/package.json | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/test-all-versions.yml b/.github/workflows/test-all-versions.yml index f272f039a54..20f54df5c38 100644 --- a/.github/workflows/test-all-versions.yml +++ b/.github/workflows/test-all-versions.yml @@ -24,7 +24,6 @@ jobs: lerna-extra-args: >- --ignore @opentelemetry/instrumentation-fastify --ignore @opentelemetry/instrumentation-restify - --ignore @opentelemetry/resource-detector-alibaba-cloud runs-on: ubuntu-latest services: mongo: diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index fc0566c6c4d..4959b4d90cd 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -13,7 +13,6 @@ jobs: include: - node: "18" lerna-extra-args: >- - --ignore @opentelemetry/resource-detector-alibaba-cloud --ignore @opentelemetry/instrumentation-restify runs-on: ubuntu-latest services: diff --git a/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json b/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json index d1f0efdf364..066173f25fb 100644 --- a/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json +++ b/detectors/node/opentelemetry-resource-detector-alibaba-cloud/package.json @@ -48,7 +48,7 @@ "@types/node": "18.11.7", "@types/sinon": "10.0.2", "mocha": "7.2.0", - "nock": "12.0.3", + "nock": "13.3.1", "nyc": "15.1.0", "rimraf": "5.0.0", "sinon": "15.0.1",