Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed Read Write Calls till after on_activate() is completed #89

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

soham2560
Copy link

In this PR

How was this tested?

  • Tested on Humble with XC330-M288T in Position Control Mode at 200HZ with JTC

@soham2560
Copy link
Author

@ijnek can you have a look at this?

@brennand
Copy link

I found a bug with this code. It doe solve the Port in Use bug. But it also means we can't read the current joint position when we active the plugin. As the reset_command() is called before activated_ = true; is set. Hence we can't read any values from the servo motor. This is the output from the this: joints_[i].command.position = joints_[i].state.position;

joints_[i].state.position: nan

@soham2560
Copy link
Author

I found a bug with this code. It doe solve the Port in Use bug. But it also means we can't read the current joint position when we active the plugin. As the reset_command() is called before activated_ = true; is set. Hence we can't read any values from the servo motor. This is the output from the this: joints_[i].command.position = joints_[i].state.position;

joints_[i].state.position: nan

aah, missed that. do you have any solution for the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TxRxResult] Port is in use! error working with XC330-M288T on ROS2 Humble
2 participants