Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError when using the old config file format #65

Open
holmboe opened this issue Sep 17, 2023 · 1 comment
Open

TypeError when using the old config file format #65

holmboe opened this issue Sep 17, 2023 · 1 comment

Comments

@holmboe
Copy link
Contributor

holmboe commented Sep 17, 2023

After #59 was merged we get this error when using the old config file format.

❯ subgit pull
Exception type : TypeError
EXCEPTION MESSAGE: string indices must be integers
To get more detailed exception set environment variable 'DEBUG=1'
To PDB debug set environment variable 'PDB=1'

Here is the traceback:

Traceback (most recent call last):
  [...]
  File "/home/nn/code/github.com/dynamist/subgit/subgit/core.py", line 354, in pull
    active_repos = self._get_active_repos(config)
  File "/home/nn/code/github.com/dynamist/subgit/subgit/core.py", line 335, in _get_active_repos
    repo_name = repo_data["name"]
TypeError: string indices must be integers
@holmboe
Copy link
Contributor Author

holmboe commented Sep 17, 2023

We should probably cut a new release quite soon.

Another reflection on this: could we handle change to the config file format better going forward? Add a version identifier? Each semver major version of subgit would expect only non-backwards compatible changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant